[Cloud Security]Added new Google Cloud icon to be used on our component#163840
Merged
animehart merged 29 commits intoelastic:mainfrom Aug 15, 2023
Merged
[Cloud Security]Added new Google Cloud icon to be used on our component#163840animehart merged 29 commits intoelastic:mainfrom
animehart merged 29 commits intoelastic:mainfrom
Conversation
…o make it easier when refactoring later
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
animehart
added
v8.10.0
release_note:skip
…-ref HEAD~1..HEAD --fix'
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
…nt (#163840) ## Summary Originally I made a PR to add the icon into eui Library, however they told me that they no longer support adding 3rd party logo into eui library as such we will need to add it to Kibana instead. This Changes includes changing the GCP logo on - Findings flyout - Benchmark flyout - Dashboard - CSPM and CNVM onboarding page (GCP tab) <img width="795" alt="Screenshot 2023-08-14 at 9 47 25 AM" src="https://github.com/elastic/kibana/assets/8703149/53e3aafa-7f3d-4c8f-b20c-ec365693ed88"> <img width="1223" alt="Screenshot 2023-08-14 at 9 33 58 AM" src="https://github.com/elastic/kibana/assets/8703149/2fcdf9ad-8088-42c4-bb32-d6cdf12d02bc"> <img width="563" alt="Screenshot 2023-08-14 at 9 35 36 AM" src="https://github.com/elastic/kibana/assets/8703149/5c63d03a-f929-4e5c-80e7-04d8327c7acb"> <img width="754" alt="Screenshot 2023-08-14 at 9 37 40 AM" src="https://github.com/elastic/kibana/assets/8703149/cd5bc65b-3118-4d1c-a943-7a12518ad5e6"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originally I made a PR to add the icon into eui Library, however they told me that they no longer support adding 3rd party logo into eui library as such we will need to add it to Kibana instead.
This Changes includes changing the GCP logo on